Remove DelayedJob worker and deliver mailers synchronously#620
Merged
Conversation
All async work in the app was mailer deliveries on low-traffic paths (sign-in welcome, authorization request/grant/alert). Switch them to deliver_now, drop the delayed_job_active_record gem, remove the worker dyno from the Procfile, and drop the delayed_jobs table. Also swap development to letter_opener so emails preview in the browser, and remove perform_deliveries=false from test.rb so assert_emails can see deliveries (delivery_method=:test still prevents real SMTP). After merge, run: heroku ps:scale worker=0 --app cherrypush-production Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deliver_now, dropdelayed_job_active_record, remove theworkerdyno fromProcfile, and drop thedelayed_jobstable.letter_openerso emails preview in the browser; removeperform_deliveries = falsefromtest.rbsoassert_emailscan see deliveries (delivery_method = :teststill prevents real SMTP).ActionMailer::Base.deliveriesinstead ofenqueued_jobs.Post-merge action
Run `heroku ps:scale worker=0 --app cherrypush-production` to retire the worker formation (~$7/mo saved).
Test plan
🤖 Generated with Claude Code